Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Refinement #1931

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Update Refinement #1931

merged 2 commits into from
Jul 19, 2024

Conversation

sampersand
Copy link
Contributor

@sampersand sampersand commented Jul 14, 2024 •
edited
Loading

This typechecks Refinement.

It only has two methods (target and a private import_methods; refined_class is deprecated in Ruby 3.4 and identical to target, so I've removed it). target is easy to typecheck, but due to a bug in ruby, import_methods has to be handled specially (calling it outside of a refine block, via send, segfaults).

@sampersand sampersand marked this pull request as ready for review July 14, 2024 05:51
@soutaro soutaro added this to the RBS 3.6 milestone Jul 19, 2024
@soutaro soutaro added this pull request to the merge queue Jul 19, 2024
soutaro
soutaro approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

Merged via the queue into ruby:master with commit 42c5e9f Jul 19, 2024
19 checks passed
@soutaro soutaro added the Released PRs already included in the released version label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@sampersand @soutaro