Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prototype] Remove redundant access modifier #1914

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[prototype] Remove redundant access modifier #1914

merged 1 commit into from
Aug 5, 2024
+0 −22

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Jun 28, 2024

Method visibility is public by default.
public is always redundant because the order in which methods appear is always guaranteed at rbs prototype runtime.

soutaro
soutaro approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this pull request to the merge queue Aug 5, 2024
@soutaro soutaro added this to the RBS 3.6 milestone Aug 5, 2024
Merged via the queue into ruby:master with commit b39885d Aug 5, 2024
19 checks passed
@ksss ksss deleted the prototype-runtime-public branch August 5, 2024 02:50
@soutaro soutaro added the Released PRs already included in the released version label Sep 17, 2024
ksss added a commit to ksss/orthoses-rails that referenced this pull request Oct 25, 2024
@ksss
Fix prototype code
466e83f 
ruby/rbs#1914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro