Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to sign git commits when running tests #1867

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Earlopain
Copy link
Contributor

I have git set up to always sign with a key that requires a password, this would require me to enter that password when running tests.

Git allows overwriting config for a single invocation, lets just do that.

@soutaro
Copy link
Member

soutaro commented Jun 6, 2024

@Earlopain Do you think moving the config to the newly created git repository makes more sense?

@Earlopain
Copy link
Contributor Author

Yes, that totally makes sense. I'll change this over in a bit

I have git set up to always sign with a key that requires a password, this would
require me to enter that password when running tests.
Git allows overwriting config for a single invocation, lets just do that
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👏

@soutaro soutaro added this to the RBS 3.5.x milestone Jun 7, 2024
@soutaro soutaro added this pull request to the merge queue Jun 7, 2024
Merged via the queue into ruby:master with commit c5bdef6 Jun 7, 2024
19 checks passed
@soutaro soutaro added the Released PRs already included in the released version label Jun 7, 2024
@Earlopain Earlopain deleted the test-gpg-signing branch June 7, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants