-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot config #1847
Dependabot config #1847
Conversation
@ParadoxV5 Any thought? |
This doesn't work correctly yet... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work correctly yet...
Good intentions, at least 👍
@@ -4,15 +4,15 @@ updates: | |||
directory: "/" | |||
schedule: | |||
interval: daily | |||
open-pull-requests-limit: 10 | |||
open-pull-requests-limit: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slow Mode 😄
Looks like the Lines 28 to 34 in 6499a09
Although… Now I’m not sure if including Gemfile has a purpose?
|
.github/workflows/dependabot.yml
Outdated
- '!Gemfile' | ||
- '!steep/Gemfile' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work?
- '!Gemfile' | |
- '!steep/Gemfile' | |
- '!**/Gemfile' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The */Gemfile
pattern would work, but the !
doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but the action didn't run with this PR. I expected to run it because this PR doesn't change none of the files in the !
pattern. So, I guess the negative (!
) pattern doesn't work without positive pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding **/*
at the top of patterns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah the if:
section at the job section blocked running the job.
Right. Will remove the |
.github/workflows/dependabot.yml
Outdated
- '!rbs.gemspec' | ||
- '!Gemfile' | ||
- '!steep/Gemfile' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or rather…?
- '!rbs.gemspec' | |
- '!Gemfile' | |
- '!steep/Gemfile' | |
- '**/Gemfile.lock' |
BTW, leverage the |
Only enable the auto-merge automacitally, if only the lockfiles are updated. We need review if `.gemspec` or `Gemfile` is updated.
14cf44d
to
9460e63
Compare
Found that simply aborting the actions is sufficient. Give it a try! |
Follow up #1833.
.gemspec
is updated, because it's a change to next releaseGemfile
is updated, just to make it more conservative