Fix memory leak when ParsingError #1830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discovered that a memory leak occurs when a
ParsingError
happens. This can occur in the following methods.RBS::Parser.parse_type
RBS::Parser.parse_method_type
RBS::Parser.parse_signature
If a global exit occurs before
free_parser
is called,free_parser
may not be called at all.I have fixed this issue by using
rb_ensure
to ensure thatfree_parser
is called under all circumstances.