Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block return type #1801

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix block return type #1801

merged 2 commits into from
Apr 22, 2024

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Apr 14, 2024

The return value of the block set by Enumerator#initialize is used as the return value of Enumerator#each, so the return value of the block should be Return.

Enumerator.new { :hello }.each {}
#=> :hello

@ksss @soutaro
Update test/stdlib/Enumerator_test.rb
e8ee102 
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
soutaro
soutaro approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.5 milestone Apr 22, 2024
@soutaro soutaro added this pull request to the merge queue Apr 22, 2024
Merged via the queue into ruby:master with commit feb8722 Apr 22, 2024
17 checks passed
@ksss ksss deleted the enum-new branch April 23, 2024 00:35
@soutaro soutaro added the Released PRs already included in the released version label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro