Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location for attribute #1787

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Add location for attribute #1787

merged 1 commit into from
Apr 6, 2024

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Apr 4, 2024

I noticed that location is not set for the attribute method. Is this intentional?

I actually have some problems with the rbs method command, such as not being able to find the location where the attribute method is defined.

I think it is better to have attribute location than not to have it, so I fixed it.


Before

$ bundle exec rbs -r rbs method --singleton RBS::Test suffix
::RBS::Test.suffix
  defined_in: ::RBS::Test
  implementation: ::RBS::Test
  accessibility: public
  types:
      () -> ::String   at

After

$ bundle exec rbs -r rbs method --singleton RBS::Test suffix
::RBS::Test.suffix
  defined_in: ::RBS::Test
  implementation: ::RBS::Test
  accessibility: public
  types:
      () -> ::String   at /Users/ksss/src/github.com/ksss/rbs/sig/test.rbs:76:4...76:37

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soutaro soutaro added this to the RBS 3.5 milestone Apr 6, 2024
@soutaro soutaro added this pull request to the merge queue Apr 6, 2024
Merged via the queue into ruby:master with commit 00bad8a Apr 6, 2024
17 checks passed
@ksss ksss deleted the attr-location branch April 6, 2024 01:42
@soutaro soutaro added the Released PRs already included in the released version label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants