Add Numeric Node's check for parse rbs #1711
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksss
reviewed
Jan 5, 2024
lib/rbs/prototype/rb.rb
Outdated
Comment on lines
701
to
702
| when :RATIONAL, :IMAGINARY | ||
| BuiltinNames::Numeric.instance_type |
There was a problem hiding this comment.
How about to like this?
Suggested change
| when :RATIONAL, :IMAGINARY | |
| BuiltinNames::Numeric.instance_type | |
| when :RATIONAL | |
| Types::ClassInstance.new(name: TypeName("::Rational"), args: [], location: nil) | |
| when :IMAGINARY | |
| Types::ClassInstance.new(name: TypeName("::Complex"), args: [], location: nil) |
There was a problem hiding this comment.
Thanks for the review!
I've fixed it in the following commit.
225ed22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll introduce Numeric Node's for the parser in ruby/ruby#9417.
This changed the behavior of the rbs parse process and caused the test to fail.
This pull request has been modified to check Numeric Node's in parse process.