[collection] Ignore directory starting with _
as version from git source
#1657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git source should allow for putting a directory starting with
_
in a gem directory.Background
I'm planning to introduce a new reviewing system to https://github.com/ruby/gem_rbs_collection.
In the new system, I'll add a new file to describe who is responsible for the gem. For example: (The file name is tentative)
But
rbs collection
interprets_reviewers.yaml
as a version. It is unexpected behavior.Solution
Ignore files/directories starting with
_
as a version.Ignoring files starting with
_
is an existing convention in RBS. So I think this behavior is natural for the users.This solution has another advantage. We can use a directory starting with
_
for another purpose. For example, we can put an RBS generator for the gem in the directory.