Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rbs diff] Load dependencies from manifest.yaml #1602

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[rbs diff] Load dependencies from manifest.yaml #1602

merged 1 commit into from
Nov 9, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Nov 8, 2023

The rbs diff command selects the environment to compare, but since manifest.yml is not read, there are cases where name resolution is not possible.

Fixed to read manifest.yml.

@ksss ksss changed the title Load dependencies from manifest.yaml [rbs diff] Load dependencies from manifest.yaml Nov 8, 2023
soutaro
soutaro approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.3 milestone Nov 9, 2023
@soutaro soutaro added this pull request to the merge queue Nov 9, 2023
Merged via the queue into ruby:master with commit cc9e876 Nov 9, 2023
23 checks passed
@ksss ksss deleted the diff-manifest-yaml branch November 9, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
RBS 3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro