Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private instance methods of Kernel #initialize_* #1540

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Add private instance methods of Kernel #initialize_* #1540

merged 2 commits into from
Sep 28, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Sep 22, 2023

  • Fix visibility for Kernel#initialize_copy
  • Add Kernel#initialize_clone
  • Add Kernel#initialize_dup

All of these should be defined as private instance methods within Kernel.

Note: These methods were discovered by #1539

@ksss ksss changed the title Kernel initialize aaa Add methods of Kernel #initialize_* Sep 22, 2023
@ksss ksss changed the title Add methods of Kernel #initialize_* Add private instance methods of Kernel #initialize_* Sep 22, 2023
soutaro
soutaro approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.3 milestone Sep 27, 2023
@soutaro soutaro added this pull request to the merge queue Sep 28, 2023
Merged via the queue into ruby:master with commit 6e73439 Sep 28, 2023
23 checks passed
@ksss ksss deleted the kernel-initialize-aaa branch September 28, 2023 11:39
@soutaro soutaro added the Released PRs already included in the released version label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro