Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures by racc/cparse was loaded from the standard library, but is not part of the default gems starting from Ruby 3.3.0 #278

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

ydah
Copy link
Member

@ydah ydah commented Jan 2, 2025

Fix following failure:

❯ ruby -v                                                                      
ruby 3.5.0dev (2024-12-25T10:12:31Z master 8f11d6cbe2) +PRISM [arm64-darwin23]
❯ bundle exec rake test
Failure: test_ifelse(Racc::TestRaccCommand)
/ydah/racc/test/test_racc_command.rb:343:in 'Racc::TestRaccCommand#test_ifelse'
<"1 useless nonterminals:\n" +
"  dummy\n" +
"2 useless rules:\n" +
"  #4 (dummy)\n" +
"  #5 (dummy)\n" +
"1 shift/reduce conflicts\n" +
"Turn on logging with \"-v\" and check \".output\" file for details\n"> expected but was
<"/ydah/racc/lib/racc/parser.rb:195: warning: racc/cparse was loaded from the standard library, but is not part of the default gems starting from Ruby 3.3.0.\n" +
"You can add racc to your Gemfile or gemspec to silence this warning.\n" +
"1 useless nonterminals:\n" +
"  dummy\n" +
"2 useless rules:\n" +
"  #4 (dummy)\n" +
"  #5 (dummy)\n" +
"1 shift/reduce conflicts\n" +
"Turn on logging with \"-v\" and check \".output\" file for details\n">

…, but is not part of the default gems starting from Ruby 3.3.0

```
Failure: test_ifelse(Racc::TestRaccCommand)
/ydah/racc/test/test_racc_command.rb:343:in 'Racc::TestRaccCommand#test_ifelse'
<"1 useless nonterminals:\n" +
"  dummy\n" +
"2 useless rules:\n" +
"  ruby#4 (dummy)\n" +
"  ruby#5 (dummy)\n" +
"1 shift/reduce conflicts\n" +
"Turn on logging with \"-v\" and check \".output\" file for details\n"> expected but was
<"/ydah/racc/lib/racc/parser.rb:195: warning: racc/cparse was loaded from the standard library, but is not part of the default gems starting from Ruby 3.3.0.\n" +
"You can add racc to your Gemfile or gemspec to silence this warning.\n" +
"1 useless nonterminals:\n" +
"  dummy\n" +
"2 useless rules:\n" +
"  ruby#4 (dummy)\n" +
"  ruby#5 (dummy)\n" +
"1 shift/reduce conflicts\n" +
"Turn on logging with \"-v\" and check \".output\" file for details\n">
```
@nobu nobu merged commit 09f6c03 into ruby:master Jan 3, 2025
31 checks passed
@ydah ydah deleted the fix-test-fail-35 branch January 3, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants