-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug symbolize_names: true
with null column yaml
#423
Fix bug symbolize_names: true
with null column yaml
#423
Conversation
``` $ rake test .... ..................................................................................................................................E...................................................................................................................................................................................................................................................................................................................................................................................................................................................... Finished in 0.434459s, 1309.6748 runs/s, 3622.8965 assertions/s. 1) Error: TestPsych#test_symbolize_names: NoMethodError: undefined method `to_sym' for nil:NilClass /repo/psych/lib/psych.rb:611:in `block in symbolize_names!' /repo/psych/lib/psych.rb:610:in `each' /repo/psych/lib/psych.rb:610:in `symbolize_names!' /repo/psych/lib/psych.rb:611:in `block in symbolize_names!' /repo/psych/lib/psych.rb:610:in `each' /repo/psych/lib/psych.rb:610:in `symbolize_names!' /repo/psych/lib/psych.rb:280:in `load' /repo/psych/test/psych/test_psych.rb:324:in `test_symbolize_names' 569 runs, 1574 assertions, 0 failures, 1 errors, 0 skips ```
This patch only fixes the YAML.load("1: n", :symbolize_names=>true) The patch should be changed to only call |
@jeremyevans thank you for the reply, appreciate. |
@jeremyevans I reflect your suggestion by 1271aa7, can you have another look? also, windows build on github action were failed, do you have any idea for it? |
This looks good to me. @tenderlove should probably review. |
@jeremyevans thank you for your support! 😀 @tenderlove could you have a look when you have time? |
This no longer applies. It looks like #480 will fix this. |
Trying to parse YAML which contains
null
columnsymbolize_names: true
would raiseNoMethodError
sample code