Prism::StringQuery #3178
Merged
Prism::StringQuery #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
force-pushed
the
string-query
branch
4 times, most recently
from
1c3e481
to
65cd2be
Compare
Introduce StringQuery to provide methods to access some metadata about the Ruby lexer.
kddnewton
force-pushed
the
string-query
branch
from
65cd2be
to
d3f55b6
Compare
k0kubun
reviewed
Oct 12, 2024
| return Qfalse; | ||
| case PM_STRING_QUERY_TRUE: | ||
| return Qtrue; | ||
| } |
There was a problem hiding this comment.
-Wreturn-type warns this:
../prism/extension.c: In function ‘string_query’:
../prism/extension.c:1156:1: warning: control reaches end of non-void function [-Wreturn-type]
1156 | }
| ^
But I'm not sure how you'd like to fix this. Should it be default: rb_bug("unreachable");?
There was a problem hiding this comment.
Ahh sorry about that, @S-H-GAMELINKS fixed this in a follow-up PR. But yeah, it should be unreachable, I'm not sure why the compiler can't figure out that the enum is exhaustive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce StringQuery to provide methods to access some metadata about the Ruby lexer.