Allow JRuby to run Rake #1170
Merged
Allow JRuby to run Rake #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows: 1. JRuby to run rake tasks 2. Allow Java to compile any generated template code For near term use this means for development work in YARP I can change a template and know with a rake run that I generated something which is at least valid Java. Note: The yarp.jar created is just put into tmp since there is no immediate plan for JRuby to consume this code as a jar (it will be imported into JRuby repo). Longer term (when fiddle impl of the gem side of YARP has landed) it will allow JRuby to test like MRI does.
jemmaissroff
approved these changes
Jul 28, 2023
|
@enebo could you add a CI check for JRuby that just builds? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows:
For near term use this means for development work in YARP I can change a template and know with a rake run that I generated something which is at least valid Java. Note: The yarp.jar created is just put into tmp since there is no immediate plan for JRuby to consume this code as a jar (it will be imported into JRuby repo).
Longer term (when fiddle impl of the gem side of YARP has landed) it will allow JRuby to test like MRI does.