Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JRuby to run Rake #1170

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Allow JRuby to run Rake #1170

merged 1 commit into from
Jul 28, 2023

Conversation

enebo
Copy link
Collaborator

@enebo enebo commented Jul 25, 2023

This PR allows:

  1. JRuby to run rake tasks
  2. Allow Java to compile any generated template code

For near term use this means for development work in YARP I can change a template and know with a rake run that I generated something which is at least valid Java. Note: The yarp.jar created is just put into tmp since there is no immediate plan for JRuby to consume this code as a jar (it will be imported into JRuby repo).

Longer term (when fiddle impl of the gem side of YARP has landed) it will allow JRuby to test like MRI does.

This PR allows:
  1. JRuby to run rake tasks
  2. Allow Java to compile any generated template code

For near term use this means for development work in YARP I can
change a template and know with a rake run that I generated something
which is at least valid Java.  Note: The yarp.jar created is just
put into tmp since there is no immediate plan for JRuby to consume
this code as a jar (it will be imported into JRuby repo).

Longer term (when fiddle impl of the gem side of YARP has landed) it
will allow JRuby to test like MRI does.
@jemmaissroff jemmaissroff merged commit 52085fd into ruby:main Jul 28, 2023
20 checks passed
@enebo enebo deleted the jruby_rake branch July 28, 2023 16:52
@kddnewton
Copy link
Collaborator

@enebo could you add a CI check for JRuby that just builds?

@enebo enebo mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants