Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extconf.rb: avoid invoking "rake" to generate templates #1155

Merged
merged 1 commit into from
Jul 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ext/yarp/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,13 @@ def build_static_rubyparser
end

def build_target_rubyparser(target)
# explicit "sh" is used for Windows where shebangs are not supported
Dir.chdir(root_dir) do
if !File.exist?("configure") && Dir.exist?(".git")
# this block only exists to support building the gem from a "git" source,
# normally we package up the configure and other files in the gem itself
Rake.sh("autoconf")
Rake.sh("autoheader")
Rake.sh("rake", "templates")
Rake.sh("templates/template.rb")
end
Rake.sh("sh", "configure") # explicit "sh" for Windows where shebangs are not supported
Rake.sh("make", target)
Expand Down