Merge pull request #2261 from haldun/haldun/fix-parsing-targets

Fix multiple assigns with newlines
ruby · Jan 26, 2024 · 6f6efa7 · 6f6efa7
2 parents 248a692 + 91b5550
commit 6f6efa7
Show file tree

Hide file tree

Showing 3 changed files with 68 additions and 38 deletions.
diff --git a/src/prism.c b/src/prism.c
@@ -11143,6 +11143,7 @@ parse_targets(pm_parser_t *parser, pm_node_t *first_target, pm_binding_power_t b
 static pm_node_t *
 parse_targets_validate(pm_parser_t *parser, pm_node_t *first_target, pm_binding_power_t binding_power) {
     pm_node_t *result = parse_targets(parser, first_target, binding_power);
+    accept1(parser, PM_TOKEN_NEWLINE);
 
     // Ensure that we have either an = or a ) after the targets.
     if (!match2(parser, PM_TOKEN_EQUAL, PM_TOKEN_PARENTHESIS_RIGHT)) {

diff --git a/test/prism/fixtures/patterns.txt b/test/prism/fixtures/patterns.txt
@@ -202,3 +202,8 @@ end
 foo => Object[{x:}]
 
 1.then { 1 in ^_1 }
+
+(
+  a,
+  b
+) = c
diff --git a/test/prism/snapshots/patterns.txt b/test/prism/snapshots/patterns.txt