Remove object_id use in OpenStruct#inspect
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2023
amomchilov
commented
Dec 18, 2023
| # Returns a string containing a detailed summary of the keys and values. | ||
| # | ||
| def inspect | ||
| ids = (Thread.current[InspectKey] ||= Set.new.compare_by_identity) |
There was a problem hiding this comment.
Using an identity Set here matches what pp does:
https://github.com/ruby/ruby/blob/e8064c6c2c317be78953b4d19226368580af0dca/lib/pp.rb#L146-L161
amomchilov
commented
Dec 18, 2023
| @@ -380,27 +380,59 @@ def delete_field(name, &block) | |||
| end | |||
| end | |||
|
|
|||
| def self.__inspect_supports_identity_set? | |||
There was a problem hiding this comment.
This is checked by the corresponding PR in set:
amomchilov
force-pushed
the
inspect-without-object_id
branch
from
f6003a8 to
6becba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while auditing uses of
object_idinruby/ruby. Pulled out from ruby/ruby#9276.This PR replaces look-ups into an Array by
object_ids, with an identity Set (seeSet#compare_by_identity). This has the same semantics but is faster and doesn't trigger allocation of IDs for these objects.On quirk here is that the
Thread.current[:__inspect_key__]value used byOpenStruct#inspectis also shared withSet#inspect. This PR provides two implementations of#inspect, depending on whether or not the matching version ofsetgem is also using an identity set. See ruby/set#33.