Fix easter_egg run without RDoc, fix input-method test run without RDoc #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Sep 3, 2024
test/irb/test_input_method.rb
Outdated
| @@ -79,7 +79,7 @@ def test_initialization_with_use_autocomplete | |||
| IRB::RelineInputMethod.new(IRB::RegexpCompletor.new) | |||
|
|
|||
| assert Reline.autocompletion | |||
| assert_not_equal empty_proc, Reline.dialog_proc(:show_doc).dialog_proc | |||
| assert_not_equal empty_proc, Reline.dialog_proc(:show_doc).dialog_proc if defined?(RDoc) | |||
There was a problem hiding this comment.
Should we use omit "...." unless defined?(RDoc) in the tests instead?
st0012
approved these changes
Sep 3, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 3, 2024
run without RDoc (ruby/irb#998) * EasterEgg no longer depend on RDoc * Run most of the input-method tests even if RDoc is not avialable ruby/irb@30fa1595d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDoc is planned to be a bundled gem, not a default gem in the future.
Even if RDoc is not available, we want to run most of the tests in
test_input_method.rb.This pull request will:
if defined?(RDoc)EasterEgg with no pager
When USE_PAGER is set to false, or no pager command is available,
IRB::Pager.pagewill fallback to STDOUT.We need to
print "\e[?1049h"to switch to alternate screen and switch back to normal screen after pager is finished because easter_egg is called while rendering document dialog.We need to
STDIN.raw { STDIN.getc }wait for more than 0 second before switch back to normal screen.