Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kill pager pid throwing Errno::ESRCH when pager process already terminated #989

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix kill pager pid throwing Errno::ESRCH when pager process already terminated #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/irb/pager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ def page(retain_content: false)
# the `IRB::Abort` exception only interrupts IRB's execution but doesn't affect the pager
# So to properly terminate the pager with Ctrl-C, we need to catch `IRB::Abort` and kill the pager process
rescue IRB::Abort
Process.kill("TERM", pid) if pid
begin
Process.kill("TERM", pid) if pid
rescue Errno::ESRCH
# Pager process already terminated
end
nil
rescue Errno::EPIPE
end
Expand Down
Loading