Stop using ExtendCommandBundle internally #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
commented
Apr 17, 2024
| @@ -265,7 +265,7 @@ def execute(_arg) | |||
| end | |||
|
|
|||
| def test_def_extend_command | |||
| IRB::Command._register_with_aliases(:foobar, FooBarCommand, [:fbalias, IRB::ExtendCommandBundle::OVERRIDE_ALL]) | |||
| IRB::ExtendCommandBundle.def_extend_command(:foobar, FooBarCommand, nil, [:fbalias, IRB::Command::OVERRIDE_ALL]) | |||
There was a problem hiding this comment.
I incorrectly updated the method called in this test in the command extension PR, so I restored it here.
|
|
||
| # This API is for IRB's internal use only and may change at any time. | ||
| # Please do NOT use it. | ||
| def _register_with_aliases(name, command_class, *aliases) |
There was a problem hiding this comment.
Since it's for internal use, I moved it to default_commands.rb instead.
This module was used to extend both commands and helpers when they're not separated. Now that they are, and we have a Command module, we should move command-related logic to the Command module and update related references. This will make the code easier to understand and refactor in the future.
st0012
force-pushed
the
split-new-and-old-command-modules
branch
from
591ac6a
to
cb35b0a
Compare
tompng
approved these changes
Apr 20, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 20, 2024
(ruby/irb#925) This module was used to extend both commands and helpers when they're not separated. Now that they are, and we have a Command module, we should move command-related logic to the Command module and update related references. This will make the code easier to understand and refactor in the future. ruby/irb@f74ec97236
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
(ruby/irb#925) This module was used to extend both commands and helpers when they're not separated. Now that they are, and we have a Command module, we should move command-related logic to the Command module and update related references. This will make the code easier to understand and refactor in the future. ruby/irb@f74ec97236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module was used to extend both commands and helpers when they're not separated. Now that they are, and we have a Command module, we should move command-related logic to the Command module and update related references.
This will make the code easier to understand and refactor in the future.