Change show_source tests into integration tests #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because show_source tests often need to define class and/or methods, they can easily leak state to other tests. Changing them to integration tests will ensure that they are run in a clean environment.
st0012
commented
Nov 28, 2023
| @@ -77,6 +77,8 @@ def method_target(owner_receiver, s_count, method, type) | |||
| target_method = target_method.super_method if target_method | |||
| end | |||
| target_method.nil? ? nil : target_method.source_location | |||
| rescue NameError | |||
There was a problem hiding this comment.
We can do more sophisticated rescue for individual instance_method and method calls. But for now with all the tests I think we can assume it's unlikely the logic itself would cause NoMethodError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always tricky to write
show_sourcetests as the state change would affectruby/ruby's CI. So this change will stop them from running onruby/ruby(because we skip integration tests there) but also make sure each test don't affect each other.I also spotted a small bug when improving tests and fixed it here too.