Display aliases in help message #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
commented
Nov 25, 2023
| @@ -16,6 +16,12 @@ def execute(*args) | |||
| commands_info = IRB::ExtendCommandBundle.all_commands_info | |||
| commands_grouped_by_categories = commands_info.group_by { |cmd| cmd[:category] } | |||
|
|
|||
| user_aliases = irb_context.instance_variable_get(:@user_aliases) | |||
There was a problem hiding this comment.
Since it's purely internal and only for this command at the moment, I don't plan to expose an API for it.
And I don't directly read IRB.conf[:COMMAND_ALIASES] here because if the user updates it in the session, help message and the actual behaviour will be out of sync.
tompng
reviewed
Nov 26, 2023
Similar to Pry, it displays user-defined aliases in the help message with a dedicated section. With the current default aliases, it looks like: ``` ...other sections... Aliases $ Alias for `show_source` @ Alias for `whereami` ```
st0012
force-pushed
the
list-aliases-in-help-message
branch
from
d8a9833
to
acff99f
Compare
tompng
approved these changes
Nov 26, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 26, 2023
(ruby/irb#788) Similar to Pry, it displays user-defined aliases in the help message with a dedicated section. With the current default aliases, it looks like: ``` ...other sections... Aliases $ Alias for `show_source` @ Alias for `whereami` ``` ruby/irb@2a0eacc891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Pry, it displays aliases in the help message with a dedicated section. With the current default aliases, it looks like:
Addresses a point in #775