Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread leak in test #758

Closed
wants to merge 1 commit into from
Closed

Conversation

tompng
Copy link
Member

@tompng tompng commented Nov 11, 2023

Ruby's leak check will catch thread (and file descriptor reading RBS) leak in TestIRB::ContextTest#test_build_completor

This pull request will wait for IRB:TypeCompletion::Types preloading thread to stop.

@tompng
Copy link
Member Author

tompng commented Nov 29, 2023

Not needed after #772

@tompng tompng closed this Nov 29, 2023
@tompng tompng deleted the fix_thread_leak_in_test branch November 29, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant