Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line option to select which completor to use #754

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

tompng
Copy link
Member

@tompng tompng commented Nov 9, 2023

Command line option is more easy to try than writing to .irbrc

irb --type-completion
irb --regexp-completion

other possibilities

--type-completor
--regexp-completor

--use-type-(completion|completor)
--use-regexp-(completion|completor)

or ENV?

ENV['IRB_COMPLETOR'] = 'type' | 'regexp'

lib/irb/init.rb Show resolved Hide resolved
lib/irb/init.rb Outdated Show resolved Hide resolved
@st0012 st0012 added the enhancement New feature or request label Nov 9, 2023
@tompng tompng force-pushed the type_completor_commandline_option branch from 1457d9d to b22a3e9 Compare November 9, 2023 13:03
@tompng
Copy link
Member Author

tompng commented Nov 9, 2023

renamed to --(type|regexp)-completor and add test

@st0012 st0012 merged commit 1dec270 into ruby:master Nov 9, 2023
24 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Nov 9, 2023
(ruby/irb#754)

* Add command line option to select which completor to use

* Add test for completor argv

ruby/irb@1dec2708c9
@tompng tompng deleted the type_completor_commandline_option branch November 9, 2023 15:56
ohbarye added a commit to ohbarye/dotfiles that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants