Fix test runner exit bug #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
approved these changes
Oct 12, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Oct 12, 2023
(ruby/irb#728) * Remove useless test setup and teardown that sets MAIN_CONTEXT to nil * Avoid adding command methods to main object in test ruby/irb@f204829a08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test-all TESTS=irbwas failing with ```irb_exit': private method `exit' called for nil (NoMethodError)`` (fixed in #727)Removes useless test setup and teardown that sets
IRB.conf[:MAIN_CONTEXT] = nil.Remove safe navigation operator of
irb_context&.exitbecause it won't be nil.Avoid
test_irb.rboverriding main object'sexitmethod because it can be a potential bug.