Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RubyLex and warn about referencing to it #692

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 23, 2023

RubyLex has always been a private component of IRB, so we should explicitly discourage usages of it.
Also, it should be placed under the IRB module like other components.

(It'd be easier to review by ignoring whitespaces with this link)

@st0012 st0012 added the enhancement New feature or request label Aug 23, 2023
@st0012 st0012 self-assigned this Aug 23, 2023
@st0012 st0012 requested a review from a team August 23, 2023 10:57
@tompng
Copy link
Member

tompng commented Aug 23, 2023

test_nesting_parser.rb uses RubyLex.ripper_lex_without_warning and it needs to be IRB::RubyLex.ripper_lex_without_warning

lib/irb/ruby-lex.rb Outdated Show resolved Hide resolved
`RubyLex` has always been a private component of IRB, so we should
explicitly discourage usages of it.
Also, it should be placed under the `IRB` module like other components.
@tompng tompng merged commit 069b562 into master Aug 24, 2023
47 checks passed
@tompng tompng deleted the deprecate-irb branch August 24, 2023 15:35
matzbot pushed a commit to ruby/ruby that referenced this pull request Aug 24, 2023
(ruby/irb#692)

`RubyLex` has always been a private component of IRB, so we should
explicitly discourage usages of it.
Also, it should be placed under the `IRB` module like other components.

ruby/irb@069b5625f7
@k0kubun
Copy link
Member

k0kubun commented Aug 25, 2023

The test has been failing on this CI: http://ci.rvm.jp/results/trunk-repeat50@ruby-sp2-docker/4695983

@peterzhu2118
Copy link
Member

@k0kubun I have a fix in #695

@st0012
Copy link
Member Author

st0012 commented Aug 26, 2023

@k0kubun sorry that I didn't notice it. I've merged @peterzhu2118's fix.

@k0kubun
Copy link
Member

k0kubun commented Aug 26, 2023

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants