Move input processing out of RubyLex #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few places that also need to check symbol aliases before `Irb#eval_input`. But since the current command test skip them, we don't have test coverage on them.
st0012
changed the title
st0012
force-pushed
the
simplify-input-processing-flow
branch
from
3ef9fed
to
9d34cde
Compare
This will save RubyLex from knowning information about commands and aliases.
st0012
force-pushed
the
simplify-input-processing-flow
branch
from
9d34cde
to
ea4c971
Compare
tompng
approved these changes
Aug 21, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 21, 2023
(ruby/irb#683) * Add a test case for Ctrl-C handling * Test symbol aliases with integration tests There are a few places that also need to check symbol aliases before `Irb#eval_input`. But since the current command test skip them, we don't have test coverage on them. * Move each_top_level_statement and readmultiline to Irb This will save RubyLex from knowning information about commands and aliases. ruby/irb@69cb5b5615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the remaining input processing logic from
RubyLextoIrb. It will enable a few refactors:RubyLex's@contextis only used to get local variables, we can remove it completely by passing locals as arguments. I will open a PR for this after this is merged.Irbcontrols a large part of an input's lifecycle (from reading to pre-evaluation), we can shorten the process or at least make it easier to understand.In addition to the refactor, I also added/improved a few test cases to cover what we were missing.