Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add black and white color to IRB::Color #676

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Add black and white color to IRB::Color #676

merged 1 commit into from
Aug 11, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 11, 2023

Although they're not used by syntax highlighting, they could be used to things like prompt.

(Since ruby/debug already depends on IRB::Color, I consider this part as public API)

@st0012 st0012 added the enhancement New feature or request label Aug 11, 2023
@tompng tompng merged commit a2763ac into master Aug 11, 2023
47 checks passed
@tompng tompng deleted the add-white-color branch August 11, 2023 16:03
matzbot pushed a commit to ruby/ruby that referenced this pull request Aug 11, 2023
@st0012 @matzbot
[ruby/irb] Add black and white color to IRB::Color
d3311e5 
(ruby/irb#676)

ruby/irb@a2763acade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tompng tompng tompng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @tompng