Reduce boilerplate code in RubyLexTest #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
refactor-ruby-lex-test
branch
from
a897fb0
to
6fbd9c6
Compare
st0012
force-pushed
the
refactor-ruby-lex-test
branch
from
6fbd9c6
to
6708368
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 18, 2023
(ruby/irb#644) * Avoid initialising Row at every test input * Extract common assertion patterns into methods * Remove unnecessary PromptRow strcut and boilerplate code ruby/irb@1ba586c0c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parentheses of
(Prompt)Row.neware very distracting when trying to read through RubyLex tests. And there are also many boilerplate in this file that can be extracted away.It'd be easier to review by commits.