Deprecate measure block usage #602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add custom command definition for `irb_measure` 2. Deprecate `measure` command's block usage This will officially remove the need to pass block to command's `execute` method, which will make future command refactoring a lot easier.
st0012
commented
Jun 10, 2023
| ::IRB::ExtendCommand::Measure.execute(irb_context, type, arg) | ||
| end | ||
| end | ||
| ], nil, __FILE__, line |
There was a problem hiding this comment.
I know this is not pretty, but this is the only way I can think of to make command refactoring easy while not introducing a n immediate breaking change.
|
I think #624 is a better way of handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
irb_measuremeasurecommand's block usageThis will officially remove the need to pass block to command's
executemethod, which will make future command refactoring a lot easier.