Fix prompt test not to change STDIO.external_encoding #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhu2118
approved these changes
Mar 2, 2023
|
I've hit the similar problem before, so I added these helpers that we can use in test setup/cleanup. |
tompng
force-pushed
the
fix_prompt_main_test_external_encoding
branch
from
7f6dd42 to
c6c8dac
Compare
tompng
force-pushed
the
fix_prompt_main_test_external_encoding
branch
from
c6c8dac to
856f744
Compare
I need it to avoid changing external_encoding I use TestInputMethod.new for not changing the encoding because not specifying the input was a fault, and also use the helper to ensure it. |
st0012
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test I added in #528, I forgot to pass TestInputMethod as input_method to
IRB::Irb.new, and it caused changing STDOUT.external_encoding fromniltoutf-8in the test case