Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify metadata to provide richer information on rubygems.org #532

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Mar 1, 2023

Since we're encouraging users to use irb as a gem, I feel it'd be worth enriching its rubygems.org page a bit and we can customise the sidebar items with the metadata attribute.

@st0012 st0012 requested a review from a team March 1, 2023 20:02
@st0012 st0012 self-assigned this Mar 1, 2023
@@ -16,6 +16,11 @@ Gem::Specification.new do |spec|
spec.homepage = "https://github.com/ruby/irb"
spec.licenses = ["Ruby", "BSD-2-Clause"]

spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = spec.homepage
spec.metadata["documentation_uri"] = spec.homepage
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specifically override the documentation's destination because the readme here has the most up-to-date info. We can modify it later when we improve the documentation on docs.ruby-lang.org.

spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = spec.homepage
spec.metadata["documentation_uri"] = spec.homepage
spec.metadata["changelog_uri"] = "#{spec.homepage}/releases"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure we don't want to maintain a CHANGELOG file yet so let's just use the release generated by GH for now, which will be enhanced after #531.

Copy link
Collaborator

@hasumikin hasumikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@st0012 st0012 merged commit f01c2a6 into master Mar 2, 2023
@st0012 st0012 deleted the update-gemspec-info branch March 2, 2023 13:49
matzbot pushed a commit to ruby/ruby that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants