Make tests more compatible with TruffleRuby #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvdrum
reviewed
Feb 3, 2023
st0012
force-pushed
the
remove-truffle-ruby-omit-1
branch
from
bd1b73b
to
5dfb92f
Compare
The test input IRB currently uses happen to hit a compatibility bug in TruffleRuby, which has been documented in oracle/truffleruby#2848 Although it'll eventually be fixed, we can make the test case support TruffleRuby now by tweaking it just a little bit. Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
The test case was added in d08ef68 to verify that IRB emits Ruby warning as expected. But the subject it uses relies on CRuby's regexp engine, which isn't always used in other language implementations, like TruffleRuby. That's why we ended up skipping TruffleRuby in this test case. Since the test isn't about regexp itself, we can change the testing subject and just remove the special condition for TruffleRuby. Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
st0012
force-pushed
the
remove-truffle-ruby-omit-1
branch
from
5dfb92f
to
5f871b4
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 9, 2023
(ruby/irb#514) * Improve encoding error test case The test input IRB currently uses happen to hit a compatibility bug in TruffleRuby, which has been documented in oracle/truffleruby#2848 Although it'll eventually be fixed, we can make the test case support TruffleRuby now by tweaking it just a little bit. Co-authored-by: Kevin Menard <kevin@nirvdrum.com> * Remove redundant TruffleRuby omits/pends Co-authored-by: Kevin Menard <kevin@nirvdrum.com> * Use a different way to test warning emission The test case was added in ruby/irb@d08ef68 to verify that IRB emits Ruby warning as expected. But the subject it uses relies on CRuby's regexp engine, which isn't always used in other language implementations, like TruffleRuby. That's why we ended up skipping TruffleRuby in this test case. Since the test isn't about regexp itself, we can change the testing subject and just remove the special condition for TruffleRuby. Co-authored-by: Kevin Menard <kevin@nirvdrum.com> --------- ruby/irb@6fdf4f3e97 Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making more tests run against TruffleRuby, we can help it match CRuby's behaviour quicker (example: oracle/truffleruby#2848).
Thanks @nirvdrum for working with me on this. We'll have regular pairing sessions to remove the rest of the skipping conditions.