Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backtrace filter for context-mode 0 #33

Merged
merged 2 commits into from
Nov 8, 2019

Conversation

youz
Copy link
Contributor

@youz youz commented Oct 30, 2019

Before:

$ irb --context-mode 0
irb(main):001:0> foo
Traceback (most recent call last):
       16: from /usr/local/lib/ruby/2.7.0/irb.rb:460:in `run'
       15: from /usr/local/lib/ruby/2.7.0/irb.rb:460:in `catch'
       14: from /usr/local/lib/ruby/2.7.0/irb.rb:461:in `block in run'
       13: from /usr/local/lib/ruby/2.7.0/irb.rb:526:in `eval_input'
       12: from /usr/local/lib/ruby/2.7.0/irb/ruby-lex.rb:125:in `each_top_level_statement'
       11: from /usr/local/lib/ruby/2.7.0/irb/ruby-lex.rb:125:in `catch'
       10: from /usr/local/lib/ruby/2.7.0/irb/ruby-lex.rb:126:in `block in each_top_level_statement'
        9: from /usr/local/lib/ruby/2.7.0/irb/ruby-lex.rb:126:in `loop'
        8: from /usr/local/lib/ruby/2.7.0/irb/ruby-lex.rb:141:in `block (2 levels) in each_top_level_statement'
        7: from /usr/local/lib/ruby/2.7.0/irb.rb:527:in `block in eval_input'
        6: from /usr/local/lib/ruby/2.7.0/irb.rb:684:in `signal_status'
        5: from /usr/local/lib/ruby/2.7.0/irb.rb:530:in `block (2 levels) in eval_input'
        4: from /usr/local/lib/ruby/2.7.0/irb/context.rb:419:in `evaluate'
        3: from /usr/local/lib/ruby/2.7.0/irb/workspace.rb:114:in `evaluate'
        2: from /usr/local/lib/ruby/2.7.0/irb/workspace.rb:114:in `eval'
        1: from (irb):1:in `block in <main>'
NameError (undefined local variable or method `foo' for main:Object)

After:

$ irb --context-mode 0
irb(main):001:0> foo
Traceback (most recent call last):
        4: from /usr/local/bin/irb:23:in `<main>'
        3: from /usr/local/bin/irb:23:in `load'
        2: from /usr/local/lib/ruby/gems/2.7.0/gems/irb-1.1.0.pre.3/exe/irb:11:in `<top (required)>'
        1: from (irb):1:in `block in <main>'
NameError (undefined local variable or method `foo' for main:Object)

@aycabta aycabta merged commit d8a0a98 into ruby:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants