Update ls.rb without requiring Set, because Set is one of standard libraries #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what I did
I replaced some codes to using Array not Set.
background of this PR
I found that
require 'set'
returnsfalse
on irb.In the case of Ruby, users usually need declare
require 'x'
to use x when it is a standard library. Set class is a standard library. So expected value ofrequire 'set'
istrue
, but actually not. I think it's a confusing.supplement
I researched the reason of this problem. The root cause of the problem seems to be rubygems from stack trace below. So only the changes in this pull request can't resolve the problem. But I think irb itself is better not to depend on standard library.