Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve history test's encoding setting #1022

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Improve history test's encoding setting #1022

merged 2 commits into from
Oct 20, 2024

Conversation

monkeyWzr
Copy link
Contributor

@monkeyWzr monkeyWzr changed the title improve history test's encoding setting Improve history test's encoding setting Oct 19, 2024
@monkeyWzr monkeyWzr mentioned this pull request Oct 19, 2024
Open
tompng
tompng approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@tompng tompng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tompng tompng merged commit 7f385bc into ruby:master Oct 20, 2024
30 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 20, 2024
@monkeyWzr @matzbot
[ruby/irb] Improve history test's encoding setting
fe17697 
(ruby/irb#1022)

* improve history test's encoding setting

* fix missing locale error for ci and refactoring

ruby/irb@7f385bc19b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tompng tompng tompng approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monkeyWzr @tompng