Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rendering test faster using updated yamatanooroti #1001

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented Sep 6, 2024

Makes test_rendering faster. Yamatanooroti's wait time is reduced from 0.1 sec to 0.01 sec
test_yamatanooroti(vterm-yamatanooroti head): 37.58 sec → 10.72 sec

startup_message

We don't need puts 'start IRB'. It does not mean IRB is ready for input. We should check the prompt with startup_message: /irb\(main\)/

close

It does not only close_input but read few bytes and terminates process immediately.
Calling close before assert_screen sometimes terminates process before reading the last output.

# because pager is invoked, foobar will not be evaluated
assert_not_match(/foobar/, screen)
assert_screen(/\A(?!foobar)/)
Copy link
Member Author

@tompng tompng Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yamatanooroti does not have assert_not_screen. We need to use negative lookahead to perform a retryable assertion.

@tompng tompng marked this pull request as ready for review September 16, 2024 18:12
@tompng tompng merged commit 2c2956b into ruby:master Oct 12, 2024
30 checks passed
@tompng tompng deleted the new_yamatanooroti branch October 12, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants