Fix PACK_MAP for unsigned types #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
force-pushed
the
unsigned-pack-map
branch
from
9742ea5 to
b81a7b7
Compare
kou
reviewed
Sep 5, 2022
|
FYI, I cherry-picked this to ruby/ruby ruby/ruby@1067441 as I needed to use this in ruby/ruby (MJIT). I'd also like to cherry-pick #111 if you're okay with it. |
|
I'm OK with it. |
|
got it, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think void* and unsigned types should be packed/unpacked as unsigned values.