Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use bundler-cache in CI #5

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Sep 14, 2021

This PR:

  • uses the bundler-cache feature of the Ruby-maintained Action setup-ruby. See ruby/setup-ruby for more information.
  • Avoids duplicate CI Jobs for Pull Requests by only running tests on the push event for "master" branch.

This change runs CI only 1 time, no duplicate Jobs for Pull Requests.
@olleolleolle olleolleolle merged commit 440c9d2 into master Sep 14, 2021
@olleolleolle olleolleolle deleted the ci-use-bundler-cache branch September 14, 2021 06:57
@olleolleolle
Copy link
Contributor Author

@nobu 👋 I hope this merge was not premature. (I guess you have a lot to review, and took a chance merging this.)

@nobu
Copy link
Member

nobu commented Sep 14, 2021

To run the tests, pushing to master or PRs are needed?

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Sep 14, 2021

@nobu One of those two, is the idea. "Are we pushing AND Is it to master?" or "Are we in a PR?".

Example of the test runs ran for my 1st commit in this PR: duplicates.

bild

...and here is the commit after that, without duplicate runs.

bild

@olleolleolle
Copy link
Contributor Author

If we need to refine the configuration somehow, let's do that. Or return to what it was before. Avoiding duplicates was my only goal, here.

@olleolleolle
Copy link
Contributor Author

I would like to add, there's another way to skip double-builds. Inspiration: thoughtbot/factory_bot#1491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants