Make sure to wait TCP/IP server to start up #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the test on TCP/IP mode sometimes fails because the debugger fails to connect to debuggee. See https://github.com/ruby/debug/actions/runs/3527685026/jobs/5917010231#step:4:338 FYI: The reason why the test has not failed until now is the test framework did not correctly detect that debuggee was terminated. Since the test framework correctly detected it from ruby/debug@6d9f231, the test began to fail, as it did this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the test on TCP/IP mode sometimes fails because the debugger fails to connect to debuggee. See https://github.com/ruby/debug/actions/runs/3527685026/jobs/5917010231#step:4:338
FYI: The reason why the test has not failed until now is the test framework did not correctly detect that debuggee was terminated. Since the test framework correctly detected it from 6d9f231, the test began to fail, as it did this time.