quit command immediately
#819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`quit` command kills Ruby process with `exit` method on the session thread. Ruby threads receives `SystemExit` exception, but it doesn't receive immediately and runs some lines after `quit` command. This patch exits the process immediately. Note that on the remote debugging `quit` command doesn't kill the debuggee process but kills remote client process and debuggee process continues the running. `quit` means kills a debugger process and on the local debugging debuggee process is on the debugger process, so that killing debugger process kills debuggee process too. fix #815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quitcommand kills Ruby process withexitmethod on the sessionthread. Ruby threads receives
SystemExitexception, but it doesn'treceive immediately and runs some lines after
quitcommand.This patch exits the process immediately.
Note that on the remote debugging
quitcommand doesn't kill thedebuggee process but kills remote client process and debuggee process
continues the running.
quitmeans kills a debugger process and on the local debuggingdebuggee process is on the debugger process, so that killing
debugger process kills debuggee process too.
fix #815