DAP: change result chars: 4096 -> 180 #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long results on DAP was clipped with 4096 chars. This patch shorten this limit to 180 chars. Compound data structure doesn't have any issue because expanding the result shows more details with corresponding values such as instance variables and so on. The problem is String object because we can not know the whole string body if it is > 180 chars. To see the whole body this patch provides `#dump` special field to show the whole body of the string and you can copy&paste the value. This patch also introduce `::DEBUGGER__::NaiveString` class. Evaluation results of instances of this class will not be clipped so if you need to get whole body of String, please wrap the string with `NaiveString` class. fix #802
ko1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long results on DAP was clipped with 4096 chars. This patch shorten
this limit to 180 chars. Compound data structure doesn't have any
issue because expanding the result shows more details with corresponding
values such as instance variables and so on.
The problem is String object because we can not know the whole string body
if it is > 180 chars. To see the whole body this patch provides
#dumpspecial field to show the whole body of the string and you can copy&paste
the value.
This patch also introduce
::DEBUGGER__::NaiveStringclass. Evaluationresults of instances of this class will not be clipped so if you need to
get whole body of String, please wrap the string with
NaiveStringclass.fix #802