🐛 Respect skip_path when returning the backtrace in ServerDAP #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Sep 6, 2022
|
@ko1 there's a failing test, but I'm not sure it's related to my changes, as the same test failed in all my other PRs 😕 |
marianosimone
commented
Sep 22, 2022
|
|
||
| path = frame.realpath || frame.path | ||
| next if skip_path?(path) | ||
| break if (levels -= 1) < 0 |
There was a problem hiding this comment.
This now needs to be after deciding to skip or not, or we'd return less frames that required
st0012
reviewed
Sep 27, 2022
st0012
reviewed
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the DAP implementation respect
skip_path, to only return frames that are not skipped.See #748