Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console application for filtering CSV #321
base: master
Are you sure you want to change the base?
Console application for filtering CSV #321
Changes from 13 commits
02a733d
c23e371
f6a7b29
e929d19
c6f9dd6
6a01bbf
8fee505
c354176
97444e7
7102e61
cdc2b47
119e98c
ebb8f48
1776b21
c3e960e
0658a05
b5cdca6
ae72bb6
a63628d
b176c63
60ff670
31c2f2f
2d67ff1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use better name? This executes
csv-filter
not a simple getter. So we should use a verb not a noun (results
) for method name. (I think that we can unify this andrun_csv_filter
and userun_csv_filter
for it...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we show
--help
for an invalid option?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meaningful test?
I think that we need to use
results_for_cli_option
notapi_output
here to testcsv-filter
.