additional CSS selector formatting #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-selector-formatting
branch
from
c711ae3 to
5d8fe83
Compare
Implement formatting for IdSelector, HashToken, PseudoClassSelector, and PseudoElementSelector. Also, add formatting test coverage.
flavorjones
force-pushed
the
flavorjones-selector-formatting
branch
from
5d8fe83 to
c152737
Compare
kddnewton
approved these changes
Jun 4, 2024
| @@ -125,7 +125,7 @@ def accept(visitor) | |||
| end | |||
|
|
|||
| def child_nodes | |||
| [type, subclasses, pseudo_elements].flatten | |||
| [type, subclasses, pseudo_elements].compact.flatten | |||
There was a problem hiding this comment.
Up to you, but you could make this:
Suggested change
| [type, subclasses, pseudo_elements].compact.flatten | |
| [type, *subclasses, *pseudo_elements] |
There was a problem hiding this comment.
Unfortunately that change doesn't account for a) type being nil and needing to be removed, and b) pseudo_elements contains nested arrays.
There was a problem hiding this comment.
While we're here, I don't really like the fact that pseudo_elements contains nested arrays (see the test "parses a compound selector with pseudo-elements and pseudo-classes" to see what it looks like), but regardless I think child_nodes should flatten it all.
|
@kddnewton If this is OK with you, would you mind merging? I've got more work that's based on this branch. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement CSS selector formatting for IdSelector, HashToken, PseudoClassSelector, and PseudoElementSelector, and add test coverage.
Also backfill coverage of the existing PseudoElementSelector AST.