Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional changes for setting Rack versioned headers #2362

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

schinery
Copy link
Contributor

Original PR: #2355

@grape-bot
Copy link

1 Warning
⚠️ Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#2362](https://github.com/ruby-grape/grape/pull/2362): Additional changed for setting rack versioned headers - [@schinery](https://github.com/schinery).

Generated by 🚫 Danger

@schinery schinery marked this pull request as ready for review October 24, 2023 21:30
@schinery schinery changed the title Additional changed for setting Rack versioned headers Additional changes for setting Rack versioned headers Oct 24, 2023
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not in love with the implementation of def self.lowercase_headers? I couldn't come up with a better one, so I'll take it.

@dblock dblock merged commit de76b5c into ruby-grape:master Oct 25, 2023
31 checks passed
@schinery schinery deleted the rack-headers-feedback branch October 25, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants