Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rack::Auth::Digest #2361

Merged
merged 12 commits into from
Oct 25, 2023
Merged

Conversation

ninoseki
Copy link
Contributor

Remove Rack::Auth::Digest.

As far as I understand, #2294 reaches a conclusion that removing Rack::Auth::Digest is the way to go.

(It's my first time to make a PR to this repository. So please let me know if I miss something)

@dblock
Copy link
Member

dblock commented Oct 24, 2023

Let's document this in UPGRADING, please?

I think we can start following major version semver from here, and bump the version of Grape to 2.0 in this PR since this is a visibly breaking change? Could you please do it?

@ninoseki
Copy link
Contributor Author

Sure, I updated README, CHANGELOG and also UPGRADING. Let me know if it's not enough or if I miss something.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 more places: The README has a "Stable Version" section that will need to say next is 2.0.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ninoseki ninoseki requested a review from dblock October 25, 2023 12:45
@dblock
Copy link
Member

dblock commented Oct 25, 2023

README#stable-release still needs a bump to 2.0, please?

@ninoseki
Copy link
Contributor Author

README#stable-release still needs a bump to 2.0, please?

Oops, I updated it by 4905cc6.

@dblock dblock merged commit 4753f67 into ruby-grape:master Oct 25, 2023
31 checks passed
@ninoseki ninoseki deleted the remove-Rack-Auth-Digest branch October 25, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants