Refactor oapi fetch task #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rubocop is failing on files which i didn't touch. Any idea how can this be solved? |
|
run |
LeFnord
reviewed
Jan 13, 2022
This helped to satisfy rubocop. Also up dated README.md. |
it seems most comes from your changes |
Refactor the |
LeFnord
reviewed
Jan 14, 2022
LeFnord
approved these changes
Jan 14, 2022
|
Hey @LeFnord, |
|
sure and thanks again |
Closed
aka-momo
pushed a commit
to aka-momo/grape-swagger
that referenced
this pull request
Feb 8, 2023
* oapi rake task generate specs for different API versions * Refactor oapi:fetch rake task generate specs per file * Fixing specs * CHANGELOG.md * Rubocop auto gen config * Update README.md * Satisfy rubocop
Bhacaz
pushed a commit
to Bhacaz/grape-swagger
that referenced
this pull request
Aug 31, 2023
* oapi rake task generate specs for different API versions * Refactor oapi:fetch rake task generate specs per file * Fixing specs * CHANGELOG.md * Rubocop auto gen config * Update README.md * Satisfy rubocop
x-yuri
reviewed
Nov 11, 2023
| "swagger_doc_#{api_version}.json" | ||
| else | ||
| ENV['store'].sub('.json', "_#{api_version}.json") | ||
| end |
There was a problem hiding this comment.
looks like a breaking change to me, which made it into v1.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oapi rake task API secs generation tasks. At the moment it generates specs for only one swagger-doc path.