Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze Rack version to 2.0.8 #773

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Freeze Rack version to 2.0.8 #773

merged 1 commit into from
Jan 20, 2020

Conversation

LeFnord
Copy link
Member

@LeFnord LeFnord commented Jan 20, 2020

  • corrects version matrix

@LeFnord
Freeze Rack version to 2.0.8
df872c5 
- corrects version matrix
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.67% when pulling df872c5 on freeze-rack-to-2.0.8 into e408f5a on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.67% when pulling df872c5 on freeze-rack-to-2.0.8 into e408f5a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.67% when pulling df872c5 on freeze-rack-to-2.0.8 into e408f5a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.67% when pulling df872c5 on freeze-rack-to-2.0.8 into e408f5a on master.

@coveralls
Copy link

coveralls commented Jan 20, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 99.669% when pulling df872c5 on freeze-rack-to-2.0.8 into e408f5a on master.

@ruby-grape ruby-grape deleted a comment from grape-bot Jan 20, 2020
@ruby-grape ruby-grape deleted a comment from grape-bot Jan 20, 2020
@LeFnord LeFnord merged commit 56806e2 into master Jan 20, 2020
@LeFnord LeFnord deleted the freeze-rack-to-2.0.8 branch January 20, 2020 17:39
@ruby-grape ruby-grape deleted a comment from grape-bot Jan 20, 2020
@urkle
Copy link
Contributor

urkle commented Jan 20, 2020

@LeFnord why are you freezing rack to a very specific version? Wouldn't having it as a minimum required be better? As with this if I have another gem in my app that needs, say, 2.0.9, I will be unable to have that and grape at the same time since this is exposed in the gemspec.

@mobilutz
Copy link

@urkle @LeFnord I am also wandering why rack is being frozen to a specific version?

dblock
dblock reviewed Jan 21, 2020
View reviewed changes
grape-swagger.gemspec
@@ -15,6 +15,7 @@ Gem::Specification.new do |s|

s.required_ruby_version = '>= 2.4'
s.add_runtime_dependency 'grape', '>= 0.16.2', '< 1.3.0'
s.add_runtime_dependency 'rack', '2.0.8'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This locks dependency to a specific version of Rack. Definitely don't want to do that as it will render grape-swagger incompatible with most apps.

Grape 1.3 is compatible with rack 2.1, there's a matrix where you can make it all work. LMK if you need help.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap I know, the problem here isn’t grape, it is grape-swagger and I’m on it.

Sorry for circumstances, if you need rack > 2.0.x use version 0.34.1, there rack isn’t frozen.

@swistaczek
Copy link
Contributor

Hey, why this version has been frozen?

@LeFnord
Copy link
Member Author

LeFnord commented Feb 3, 2020

please read the comment above

aka-momo pushed a commit to aka-momo/grape-swagger that referenced this pull request Feb 8, 2023
@LeFnord @aka-momo
Freeze Rack version to 2.0.8 (ruby-grape#773)
36d81f9 
- corrects version matrix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LeFnord @coveralls @urkle @mobilutz @swistaczek @dblock